Nfc implementation#40
Draft
xchapron-ledger wants to merge 6 commits into
Draft
Conversation
added 5 commits
May 2, 2024 11:20
xchapron-ledger
commented
May 16, 2024
xchapron-ledger
force-pushed
the
xch/test-nfc
branch
2 times, most recently
from
55d2793 to
7e08515
Compare
xchapron-ledger
commented
May 17, 2024
Comment on lines
+385
to
+386
| // TODO: is this what we want? | ||
| // TODO: Handle cases where availableCredentials is != 1 |
xchapron-ledger
commented
May 17, 2024
| ctap2_make_credential_ux(); | ||
| if (CMD_IS_OVER_U2F_NFC) { | ||
| // No up nor uv requested, skip UX and reply immediately | ||
| // TODO: is this what we want? |
xchapron-ledger
commented
May 17, 2024
| return io_send_sw(SW_INS_NOT_SUPPORTED); | ||
| } | ||
| } else if (CMD_IS_OVER_U2F_NFC && (rx[OFFSET_CLA] == FIDO2_NFC_CHAINING_CLA)) { | ||
| // TODO but as of now it's not used neither on: |
Contributor
Author
There was a problem hiding this comment.
TODO as Android might start using FIDO2 anytime soon, and at this point it will probably continue using short encoding?
xchapron-ledger
commented
May 17, 2024
Contributor
Author
|
@lpascal-ledger FYI |
Tested with Android on Pixel 5 and iOS. Some todo remains.
xchapron-ledger
force-pushed
the
xch/test-nfc
branch
from
7e08515 to
7c6d637
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to look at the comments !