Skip to content

Hardening + porting to Apex P#10

Merged
iartemov-ledger merged 5 commits into
developfrom
update_hardening
Mar 23, 2026
Merged

Hardening + porting to Apex P#10
iartemov-ledger merged 5 commits into
developfrom
update_hardening

Conversation

@iartemov-ledger
Copy link
Copy Markdown
Contributor

@iartemov-ledger iartemov-ledger commented Mar 20, 2026

Initial motivation for the work was to port the app to Apex.
Also we have a strategy of least permission.
As this application is a L2 on top of bitcoin using app-bitcoin-new@baseapp branch as dependency the both goals can be achieved by the upgrading of the dependency to its current head.

  • allowed derivation path limited to "*/0'" "4541509'" "45'" (or to "*/1'" "4541509'" "45'" for testnet)
  • APPLICATION_FLAG_DERIVE_MASTER removed
  • Porting to Apex P
  • Some adaptation of the app's code to the updated baseapp branch
  • Version bump + CHANGELOG
  • Snapshot update
  • to remove artificial, for-test-only commit 2860e65
  • to be merged first as dependency app-core hardening ledger-app-database#470

@pollastri-pierre can it be an issue for this application - the derivation path hardening applied ?

@iartemov-ledger iartemov-ledger marked this pull request as ready for review March 20, 2026 10:53
@iartemov-ledger iartemov-ledger changed the title Update hardening Hardening + porting to Apex P Mar 20, 2026
@pollastri-pierre
Copy link
Copy Markdown
Member

@iartemov-ledger I'm not familiar with this way to express derivation path "*/0'" "4541509'" "45'"

The app needs access to the same path as the bitcoin app + it needs access to m/84h/[0-1]h/0h/0/0 (which is native segwit so if the app has access to default wallet policy paths, it already have access to that)

@iartemov-ledger
Copy link
Copy Markdown
Contributor Author

@iartemov-ledger I'm not familiar with this way to express derivation path "*/0'" "4541509'" "45'"

The app needs access to the same path as the bitcoin app + it needs access to m/84h/[0-1]h/0h/0/0 (which is native segwit so if the app has access to default wallet policy paths, it already have access to that)

Thank you @pollastri-pierre !
With "*/0'" / "*/'" syntax we ensure the access to any purposes including the Native segwit one (84').

Copy link
Copy Markdown

@tdejoigny-ledger tdejoigny-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you sideload on Nano Gen 5 ?

Comment thread .github/workflows/guidelines_enforcer.yml Outdated
@tdejoigny-ledger
Copy link
Copy Markdown

tdejoigny-ledger commented Mar 23, 2026

@iartemov-ledger LGMT, sideload ok

@iartemov-ledger
Copy link
Copy Markdown
Contributor Author

Did you sideload on Nano Gen 5 ?

I had side-loaded on Apex of course.
But indeed, the icon and the glyph were both grayscale, and still displayed fine.
Anyway I've just converted the both to bilevel.
@tdejoigny-ledger , could you please re-approve?

@iartemov-ledger iartemov-ledger merged commit eb76c37 into develop Mar 23, 2026
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants