Pokemon-Terminal v2.0 Fork Modernization: Packaging, CI/CD, Cross-Platform npm Wrapper, and Docs Refresh#223
Open
Crimson341 wants to merge 7 commits intoLazoVelko:masterfrom
Open
Pokemon-Terminal v2.0 Fork Modernization: Packaging, CI/CD, Cross-Platform npm Wrapper, and Docs Refresh#223Crimson341 wants to merge 7 commits intoLazoVelko:masterfrom
Crimson341 wants to merge 7 commits intoLazoVelko:masterfrom
Conversation
Address kitty setup feedback
Modernize packaging and release workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR delivers a full v2.0 modernization of the fork, including packaging, CI/CD, npm wrapper reliability, and documentation updates.
What Changed
Packaging and Project Metadata
pyproject.toml(PEP 621 + setuptools backend).setup.pycompatibility shim.2.0.0.>=3.10.Development Status :: 4 - Betasetuptools>=69Crimson341/Pokemon-Terminal.Tooling and Dependencies
pytestruffbuildtwineMakefiletargets:setup,lint,test,build,package-check,dry-run,kitty-setup.CI/CD and Automation
npm Wrapper and Cross-Platform Behavior
pokemonichooseyoubin/pokemon.js) that:>=3.10python -m pokemonterminal.mainnpx --no-install pokemon --helpnpx --no-install ichooseyou --helpfor Windows-safe command resolution.
Documentation and README
Crimson341).make setup,make kitty-setup).Validation
make lintpassesmake testpasses (54 passed)python -m buildsucceedstwine check dist/*succeedspokemon --helpandichooseyou --helpwork via local npm installNotes