Fix issue #197: Ctrl+C interrupt no longer causes Traceback error when slideshow is cleared#212
Open
CullenLYe wants to merge 1 commit intoLazoVelko:masterfrom
Open
Fix issue #197: Ctrl+C interrupt no longer causes Traceback error when slideshow is cleared#212CullenLYe wants to merge 1 commit intoLazoVelko:masterfrom
CullenLYe wants to merge 1 commit intoLazoVelko:masterfrom
Conversation
…error when slideshow is cleared.
Collaborator
|
I'm not sure this fix gives the intended behavior here. I believe the user wants the slideshow to keep going, while this change will make it stop. A more ideal resolution is probably to somehow detach the worker process from the terminal so that it doesn't get input anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to Issue#197:
When a slideshow is running, if the user holds down Ctrl+C (Keyboard Interrupt) and then proceeds to clear the slideshow using the -c flag, a Traceback occurs and is printed to the Terminal:
I added a try/except block to catch when a Keyboard Interrupt occurs. Now, if the user clears the slideshow, no Traceback is printed:
