Skip to content

Stop generating controller-first URLs #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-adam merged 1 commit into from
Feb 20, 2026
Merged

Stop generating controller-first URLs #1179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions src/org/labkey/targetedms/TargetedMSController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,6 @@
import org.labkey.api.security.permissions.InsertPermission;
import org.labkey.api.security.permissions.ReadPermission;
import org.labkey.api.security.permissions.UpdatePermission;
import org.labkey.api.settings.AppProps;
import org.labkey.api.targetedms.RepresentativeDataState;
import org.labkey.api.targetedms.RunRepresentativeDataState;
import org.labkey.api.targetedms.TargetedMSService;
Expand Down Expand Up @@ -6464,13 +6463,10 @@ public static PopupMenu createDownloadMenu(@NotNull TargetedMSRun run)
navTree.addChild(fullDownloadNavTree);

ActionURL runURL = new ActionURL(ShowPrecursorListAction.class, run.getContainer()).addParameter("fileName", run.getFileName());
if (AppProps.getInstance().getUseContainerRelativeURL())
{
NavTree relativeURLNavTree = new NavTree("Copy relative URL to clipboard", runURL.toContainerRelativeURL());
relativeURLNavTree.setScript("copyStringToClipboard(" + PageFlowUtil.jsString(runURL.toContainerRelativeURL()) + ");return false;");
relativeURLNavTree.setTip("Relative URLs are good for using in wiki pages in this folder, especially for folders that may later move or be copied");
navTree.addChild(relativeURLNavTree);
}
NavTree relativeURLNavTree = new NavTree("Copy relative URL to clipboard", runURL.toRelativeURL());
relativeURLNavTree.setScript("copyStringToClipboard(" + PageFlowUtil.jsString(runURL.toRelativeURL()) + ");return false;");
relativeURLNavTree.setTip("Relative URLs are good for using in wiki pages in this folder, especially for folders that may later move or be copied");
navTree.addChild(relativeURLNavTree);

NavTree fullURL = new NavTree("Copy full URL to clipboard", runURL.getURIString());
fullURL.setScript("copyStringToClipboard(" + PageFlowUtil.jsString(runURL.getURIString()) + ");return false;");
Expand Down