Conversation
Add configurable tracking of maximum packet sizes during flow extraction. Users can now enable tracking via FlowConfig parameters to measure: - Maximum packet length per direction (forward_max_packet_len, reverse_max_packet_len) - Maximum packet length across entire flow (max_flow_len) Tracking is disabled by default for zero overhead. When enabled, adds minimal O(1) overhead per packet. Changes: - FlowConfig: new track_max_packet_len and track_max_flow_len flags (default: false) - DirectionStats: added max_packet_len field, updated record_packet() to track - ConversationState: added max_flow_len field for overall maximum - PyFlowConfig: expose tracking flags to Python API with defaults - PyConversation: three new properties (forward_max_packet_len, reverse_max_packet_len, max_flow_len) Added comprehensive test suite with 8 tests covering: - Default behavior (no tracking) - Single-direction tracking - Bidirectional tracking - Overall flow maximum - Multiple packets verification - Protocol isolation - Enable/disable toggle All tests passing: 32 total (24 existing + 8 new)
Add comprehensive documentation for: - Maximum packet/flow length tracking (optional, off by default) - ICMP and ICMPv6 echo request/reply correlation - Message type handling for non-echo ICMP flows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.