add notebook generating 3D plots comparing SLSim lenses and SLACS Dinos lenses#354
Open
mia-lamontagne wants to merge 2 commits intoLSST-strong-lensing:mainfrom
Open
add notebook generating 3D plots comparing SLSim lenses and SLACS Dinos lenses#354mia-lamontagne wants to merge 2 commits intoLSST-strong-lensing:mainfrom
mia-lamontagne wants to merge 2 commits intoLSST-strong-lensing:mainfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #354 +/- ##
==========================================
+ Coverage 97.93% 98.28% +0.34%
==========================================
Files 154 98 -56
Lines 10479 6420 -4059
==========================================
- Hits 10263 6310 -3953
+ Misses 216 110 -106 🚀 New features to boost your workflow:
|
Collaborator
|
Hi @mia-lamontagne , thank you very much for this PR! It is failing pre-commit. It would be great if you could fix them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This notebook compares various parameters of simulated SLSim lenses to real observed SLACS Dinos lenses, and displays them as corner plots as well as 3D plots for enhanced visualization.