Extract prompt building logic into build_all_requests() function#88
Open
qianchongyang wants to merge 1 commit intoLLMSQL:mainfrom
Open
Extract prompt building logic into build_all_requests() function#88qianchongyang wants to merge 1 commit intoLLMSQL:mainfrom
qianchongyang wants to merge 1 commit intoLLMSQL:mainfrom
Conversation
Created a shared build_all_requests() function in utils.py that handles: - Building prompts from questions and tables - Optional chat template application via tokenizer Updated inference_vllm.py and inference_api.py to use the new function, removing duplicate prompt building logic. Fixes LLMSQL#62
Collaborator
|
Hi @qianchongyang , thank you for your contribution! Your work will be merged after check. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, prompt creation logic is duplicated across multiple inference functions. This leads to code redundancy and makes it difficult to apply consistent chat templates or modify prompt formats.
Solution
Created a new
build_all_requests()function that centralizes prompt generation. The function handles:All inference functions now call this shared function instead of duplicating the logic.
Validation
Fixes #62