Skip to content

Add curl to the image#169

Open
tvami wants to merge 1 commit intomainfrom
iss168-add-curl
Open

Add curl to the image#169
tvami wants to merge 1 commit intomainfrom
iss168-add-curl

Conversation

@tvami
Copy link
Member

@tvami tvami commented Mar 5, 2026

I am adding a new package to the container, here are the details.

Resolves #168

What new packages does this PR add to the development image?

  • libcurl4-openssl-dev

Check List

  • I successfully built the container using docker
  • I was able to build ldmx-sw using this new container build
  • I was able to test run a small simulation and reconstruction inside this container
  • I was able to successfully use the new packages.

@tvami tvami requested a review from tomeichlersmith March 5, 2026 18:43
Copy link
Member

@tomeichlersmith tomeichlersmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me, obviously wait to merge until after build succeeds in the next two days (maybe also make sure you can compile a simple test program that uses libcurl? to make sure the installation is functional)

@tomeichlersmith
Copy link
Member

Oh! And don't forget to update the docs/ubuntu-packages.md listing with why this package is included.

@tvami
Copy link
Member Author

tvami commented Mar 5, 2026

Sounds good, I'll do it after the CI checks finished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add libcurl

2 participants