fix parser: use context extend from nodes.util#1403
Merged
Conversation
Contributor
Author
|
For example (before changes) local s_mathonly = ls.extend_decorator.apply(s, {}, { condition = tex.math_mode })
local s_mathonlyy = ls.extend_decorator.apply(s, { condition = tex.math_mode })
local parse_mathonly = ls.extend_decorator.apply(parse, { condition = tex.math_mode })
local math_auto = {
}
local greek = {
parse_mathonly({ trig = "@a" }, "\\alpha"),
parse_mathonly("@h", "\\alpha"),
s_mathonly("@g", t("\\gamma")),
s_mathonlyy("@u", t("\\gamma")),
}
vim.list_extend(math_auto, greek)
return {}, vim.list_extend(text_auto, math_auto)
|
Replace local `context_extend` with `nodes.util.snippet_extend_context` Previously, when passing a string as the first argument (context), the parser ignored the 'extend' parameters. The local context_extend function did not merge extend fields if context was a string. Now, using node_util.snippet_extend_context ensures that extend parameters are correctly merged regardless of whether context is a string or a table.
a2ddf31 to
07978a7
Compare
Owner
|
Hey, sorry for the (very) late reply :/ This looks like something that I should've done in the first place, Thank You! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace local
context_extendwithnodes.util.snippet_extend_contextThe default extend behavior was inconsistent between the functions (
ls.snippetandls.parser.parse_snippet/ls.parser.parse_snipmate)Previously, when passing a string as the first argument (context), the parser ignored the 'extend' parameters (while
ls.snippetnot). The localcontext_extendfunction did not merge extend fields if context was a string. Now, usingnodes.util.snippet_extend_contextensures that extend parameters are correctly merged regardless of whether context is a string or a table.