fix: anonymize all personal data from framework codebase#42
Conversation
- cli.py: replace hardcoded 'Pastorsimon1798' default owner with ARCHAEOLOGY_GITHUB_OWNER env var (empty default) - github_fetcher.py: same env var substitution for _DEFAULT_OWNER - agent_benchmark.py: normalize_author now returns 'Human' for all non-AI authors (no personal names); rename CSS/JS token simon→human - api.py: remove 'The-Factory' project reference from module docstring - db/queries.py: remove 'Liminal case study' reference from comment - report.py: remove 'Liminal' project name from demo README text - demo deliverables: replace 'Simon', 'Jake Van Clief', 'mcp-video' narrative with generic anonymized equivalent
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughThis PR removes hardcoded references to a specific person (Simon) and product (Liminal/The-Factory) across multiple modules. Configuration defaults shift from hardcoded to environment variables, agent visualization logic treats unknown authors as generic "Human" instead of preserving names, and documentation is updated to use neutral language. ChangesDepersonalization and Generalization
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56ca71d3f4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| @main.command("fetch-github") | ||
| @click.option("--owner", default="Pastorsimon1798", help="GitHub username/org") | ||
| @click.option("--owner", default=os.environ.get("ARCHAEOLOGY_GITHUB_OWNER", ""), help="GitHub username/org") |
There was a problem hiding this comment.
Require an owner before calling gh
When ARCHAEOLOGY_GITHUB_OWNER is unset and the user runs archaeology fetch-github without --owner, this default becomes "", but the fetcher still passes it as a positional owner to gh repo list rather than omitting the optional argument. The GitHub CLI manual documents the syntax as gh repo list [<owner>], so defaulting to an explicit empty string can make the default command fail or fetch no repos instead of either using the authenticated user/default behavior or giving an actionable error; validate this value or omit the positional argument when it is blank.
Useful? React with 👍 / 👎.
Removes all personal identifiers that leaked into the public framework:
Code defaults:
cli.py:--ownerdefault wasPastorsimon1798→ now reads fromARCHAEOLOGY_GITHUB_OWNERenv vargithub_fetcher.py: same_DEFAULT_OWNERfixagent_benchmark.py:normalize_author()returned 'Simon' for any human author → now returns 'Human' for all non-AI names; CSS/JS token--simon→--humanReferences in source:
api.py: removed 'The-Factory' from module docstringdb/queries.py: removed 'Liminal case study' from commentreport.py: removed 'Liminal' from demo README textDemo deliverables:
deliverables/archaeology.htmlanddeliverables/visuals/archaeology.htmlhad a callout with 'Jake Van Clief', 'Simon's first-ever PR', and 'mcp-video' — replaced with anonymized generic equivalentNeed help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.Summary by CodeRabbit
Configuration
Visualization
Content Updates