fix(template): replace hardcoded era data with dynamic LEARNING.topicEvolution#41
Conversation
…Evolution - Chart 2 (Topic Evolution): was hardcoded with Liminal project era data (Era 1/2/3 refs caused era scanner false positives on all other projects) Now reads from LEARNING.topicEvolution — shows noData() if absent - search_timeline: use s.query || s.title with 'Searched for' prefix stripped (defensive fallback handles both field name conventions)
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughTwo visualization charts in a template are updated: the Learning Curve chart derives eras from runtime data with empty-data handling, and the Search Timeline chart extracts query text from data properties with prefix stripping. ChangesVisualization Template Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: faec1129fb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const eras = LEARNING.topicEvolution || []; | ||
| if (!eras.length) { noData(el, 'Topic evolution data not available', 380); return; } |
There was a problem hiding this comment.
Populate topic evolution before requiring it
When reports are generated through the inspected visualize path, PROJECT_DATA is just the inlined deliverables/data.json plus commit-era top-level fields (archaeology/cli.py lines 530-545), and the data generator does not emit learning.topicEvolution at all (scripts/data/generate_data_json.py builds only telemetry/codebase/developer fields). With this change, those normal generated reports take the [] fallback and always render “Topic evolution data not available,” so the chart disappears for every project unless someone hand-edits a non-produced field into the JSON.
Useful? React with 👍 / 👎.
Two template fixes that eliminate era scanner false positives across all projects:
Chart 2 (Topic Evolution)
Was hardcoded with Liminal-specific era data (
Era 1,Era 2,Era 3named refs). Every other project's era scanner was flagging these as stale references against their own commit-eras.json. Now reads fromLEARNING.topicEvolution— populated from YouTube AI video topic breakdown per phase. Shows noData() if absent.search_timeline
Was accessing
s.querybut the data pipeline writess.title. Added fallback:s.query || s.titlewith'Searched for 'prefix stripped.Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.Summary by CodeRabbit