Skip to content

Add finalizers permission for APIKeyRequest owner references #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eguzki merged 2 commits into from
May 25, 2026
+7 −1
Merged

Add finalizers permission for APIKeyRequest owner references #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e55252c
Added the missing RBAC permission to update finalizers on apikeyrequests
eguzki May 23, 2026
9682856
remove unnecessary noisy error log
eguzki May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions config/rbac/role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,12 @@ rules:
- get
- patch
- update
- apiGroups:
- devportal.kuadrant.io
resources:
- apikeyrequests/finalizers
verbs:
- update
- apiGroups:
- devportal.kuadrant.io
resources:
Expand Down
2 changes: 1 addition & 1 deletion internal/controller/apikeyapproval_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ type APIKeyApprovalReconciler struct {

// +kubebuilder:rbac:groups=devportal.kuadrant.io,resources=apikeyapprovals,verbs=get;list;watch;update;patch;delete
// +kubebuilder:rbac:groups=devportal.kuadrant.io,resources=apikeyrequests,verbs=get;list;watch
// +kubebuilder:rbac:groups=devportal.kuadrant.io,resources=apikeyrequests/finalizers,verbs=update

// Reconcile handles reconciling all APIKeyApprovals in a single call. Any resource event should enqueue the
// same reconcile.Request containing this controller name, i.e. "apikeyapproval". This allows multiple resource updates to
Expand Down Expand Up @@ -124,7 +125,6 @@ func (r *APIKeyApprovalReconciler) reconcileOwnerReference(ctx context.Context,

// Update the APIKeyApproval with the owner reference
if err := r.Update(ctx, approval); err != nil {
logger.Error(err, "Failed to update APIKeyApproval with owner reference")
return err
}

Expand Down
Loading