fix: justification fix, beam offset calc fixes, ifc and glb export fixes and more#182
fix: justification fix, beam offset calc fixes, ifc and glb export fixes and more#182oleandor wants to merge 25 commits intoKrande:mainfrom
Conversation
…. aim to have one way for all gxml, glb, ifc etc
… mass calc taking axial offset into account, glb and ifc now show correct offsets also when offsets are different at each end
|
@Krande, please have a look when you find the time. test_write_step seems to fail, and i sort of understand why, not sure what is the best way to handle it. we could set the section made by outer_poly to general section, and then try to calc the Cgy, Cgz ect, - or we can just bypass it in curve_offset_local. not sure how much this outer_poly defiend section is used |
|
Hey, sorry for slow response. Thanks for this PR! Will try to take a look this week or the next:) |
|
I think I’ve solved it now. The COG calculation should now be consistent with the ADA model definition, GXML export/import, FEM import, beam justifications, visualizations in the ADA viewer, as well as IFC and GLB exports. I’ve also updated the Para model based on this PR, so hopefully you’re happy with the changes and we can release the Para model with this dependency update. 🙂 |
|
👋 Hi there! I have checked your PR and found no issues. Thanks for your contribution! PR Review:I found no pr-related issues.
Python Review:I found no python-related issues. Python Linting results:
Python Packaging results:
|
No description provided.