fix: validate resolution using predefined constants instead of numeric literals#27
Open
fix: validate resolution using predefined constants instead of numeric literals#27
Conversation
|
|
Luacheck Report1 tests 1 ✅ 0s ⏱️ Results for commit 2f91feb. ♻️ This comment has been updated with latest results. |
…stead of numeric literals
ms2008
force-pushed
the
chore/use-predefined-constants
branch
from
f7a470a to
2f91feb
Compare
ADD-SP
approved these changes
May 10, 2024
ADD-SP
changed the title
ADD-SP
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as mentioned in the title