Conversation
…nd equipment manager
Introduce a new EllesmereUIMythicTimer module (standalone timer + options) and wire it into the main UI. - Add EllesmereUIMythicTimer/EllesmereUIMythicTimer.lua: standalone Mythic+ timer overlay, run/objective tracking, HUD rendering, and Blizzard M+ suppression. - Add EllesmereUIMythicTimer/EUI_MythicTimer_Options.lua: options page registration and controls for the new module. - Update EllesmereUI.lua to register the new module so it appears in the sidebar. - Integrate Mythic+ rendering into the QuestTracker (EllesmereUIBasics_QuestTracker.lua) so the sidebar can show the M+ section.
Adding dependency to EUI.lua
Added in suppression of QuestTracker for Blizzard Quest Tracker.
…nd equipment manager Equipment panel improvements: - Add New Set, Equip, and Save buttons with pixel-perfect borders - Implement pixel-perfect borders using EllesmereUI.PanelPP system - Add hover effects with turquoise color transitions on all buttons - Display "Equipped" message on Equip button click - Add delete button (X) to remove equipment sets - Auto-equip sets when spec changes - Track and restore last equipped set on login Character sheet UI refinements: - Implement pixel-perfect borders for equipment buttons - Add font customization options (shadow and outline) for ItemLevel, UpgradeTrack, and Enchant text - Make character model visible with proper FrameLevel layering Visual consistency: - Change item slot borders from yellow/default to dark gray (0.4, 0.4, 0.4) - Update empty slot backgrounds to gray - Match button text colors to UI theme (white with turquoise hover effect) - Implement darker turquoise hover border colors Dynamic updates: - Add UNIT_INVENTORY_CHANGED event listener for real-time border color updates - Borders now reflect item rarity colors when equipped UI cleanup: - Remove spacing gaps in Character Panel Customizations menu - Ensure text labels appear above character model
- Only show average itemlevel, stats panel background, and scrollbars on Character tab - Hide all stat section containers when switching away from Character tab - Only refresh socket icons and show socket container if on Character tab - Fix socketWatcher to only update sockets when on Character tab and frame is shown - Ensure clean tab switching without leftover UI elements
**Fixed:** - Combat lockdown errors in Equipment Manager - Item caching with different upgrade levels - Secondary stat tooltip colors **Added:** - Raw stat values and combat ratings for secondary stats - Mythic+ Rating display - Equipment set completion indicator (red = incomplete) - Missing items tooltip - Real-time equipment monitoring
Character Panel Redesign - Reorganized UI layout - Themed Character Sheet cogwheel with scale slider - Custom color pickers for all stat categories - Auto-disable related options when theme is off Upgradetrack, Itemlevel & Enchants - Cogwheel menus with Font Size, Shadow & Outline options - Custom color picker for each - Color picker auto-disables when toggled off Crests System - Seasonal max now dynamically fetched from WoW API - Fixed currency IDs (Champion: 3343, Adventurer: 3383) Enchant Display - Shows "" in red for enchantable slots - Only appears on relevant slots (Head, Shoulders, Back, Chest, etc.)
The PLAYER_SPECIALIZATION_CHANGED event was being fired by WoW even when the specialization didn't actually change, particularly when joining groups or when guild members come online. This caused equipment sets to be auto-equipped unnecessarily. Track the previous specialization index and only trigger auto-equipping when it actually changes. This prevents spurious equipment changes from false events while preserving the intended auto-equip functionality.
Add a new Best Runs viewer tab (EUI_MythicTimer_BestRuns.lua) that parses stored bestRuns, displays per-dungeon/level runs, shows objective splits, allows deleting runs (with confirmation) and includes font helpers and test data injection for development. Update the options UI (EUI_MythicTimer_Options.lua) to add presets, font selection, an Advanced Mode toggle and many new/advanced settings (affix display, compare modes, enemy forces format/position, objective time position, layout and color controls, clear-best-times button, etc.). Refactor config setters (Set/SetPreset), add RebuildPage/IsAdvanced helpers, and wire the Best Runs page into the settings builder so the new viewer is shown under the sidebar. (Also add .toc/main changes to register the new module.)
…heet Add themed character sheet with custom layouts
Fixing reset function to fully reset the module to base settings.
Add Mythic+ Timer module and UI hooks
Update dungeon completion logic to track if the last dungeon was completed. Prior if a last boss was defeated and completion happened at the same time, we'd miss the run complete. Added logic to handle this and to handle if trash is done after final boss to avoid false positives on best runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.