Skip to content

Further Model Size Reductions #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josephbirkner merged 5 commits into from
Mar 16, 2026

model: address split storage review comments

9a3911b
Select commit
Loading
Failed to load commit list.
Merged

Further Model Size Reductions #137

model: address split storage review comments
9a3911b
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 9, 2026 in 50s

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 536 in include/simfil/model/column.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "enable_if" with a language construct (i.e. use an abbreviate function template, a "requires" clause, or an "if constexpr"). 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZzDMvCl6WEbhw289ciT&open=AZzDMvCl6WEbhw289ciT&pullRequest=137

Check warning on line 807 in include/simfil/model/column.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "reinterpret_cast" with a safer operation. 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZzDMvCl6WEbhw289ciY&open=AZzDMvCl6WEbhw289ciY&pullRequest=137

Check warning on line 596 in include/simfil/model/column.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Keep operator== and remove operator!= for operand types "basic_iterator" and "basic_iterator". 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZzDMvCl6WEbhw289ciZ&open=AZzDMvCl6WEbhw289ciZ&pullRequest=137

Check failure on line 587 in include/simfil/model/arena.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

const_cast removing const qualification from the type of a reference may lead to an undefined behaviour. 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZzDMvCU6WEbhw289ciP&open=AZzDMvCU6WEbhw289ciP&pullRequest=137

Check failure on line 376 in test/arena.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"std::forward" is never called on this forwarding reference argument. 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZzDMu9I6WEbhw289ciM&open=AZzDMu9I6WEbhw289ciM&pullRequest=137

Check failure on line 376 in test/arena.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables. 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZzDMu9I6WEbhw289ciL&open=AZzDMu9I6WEbhw289ciL&pullRequest=137

Check warning on line 527 in include/simfil/model/column.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "enable_if" with a language construct (i.e. use an abbreviate function template, a "requires" clause, or an "if constexpr"). 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZzDMvCl6WEbhw289ciS&open=AZzDMvCl6WEbhw289ciS&pullRequest=137

Check warning on line 549 in include/simfil/model/arena.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "singletonOrdinal" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZzDMvCU6WEbhw289ciN&open=AZzDMvCU6WEbhw289ciN&pullRequest=137

Check failure on line 519 in include/simfil/model/column.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this conversion operator with a function or (C++11) add the "explicit" keyword. 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZzDMvCl6WEbhw289ciU&open=AZzDMvCl6WEbhw289ciU&pullRequest=137

Check failure on line 596 in include/simfil/model/arena.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 27 to the 25 allowed. 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZzDMvCU6WEbhw289ciQ&open=AZzDMvCU6WEbhw289ciQ&pullRequest=137

Check failure on line 575 in include/simfil/model/column.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add the "explicit" keyword to this constructor. 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZzDMvCl6WEbhw289ciV&open=AZzDMvCl6WEbhw289ciV&pullRequest=137

Check warning on line 608 in include/simfil/model/arena.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this conditional structure or edit its code blocks so that they're not all the same. 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZzDMvCU6WEbhw289ciR&open=AZzDMvCU6WEbhw289ciR&pullRequest=137

Check warning on line 596 in include/simfil/model/column.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "=default" instead of the default implementation of this comparison function. 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZzDMvCl6WEbhw289ciX&open=AZzDMvCl6WEbhw289ciX&pullRequest=137

Check failure on line 578 in include/simfil/model/arena.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

const_cast removing const qualification from the type of a reference may lead to an undefined behaviour. 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZzDMvCU6WEbhw289ciO&open=AZzDMvCU6WEbhw289ciO&pullRequest=137

Check warning on line 576 in include/simfil/model/column.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove these redundant parentheses. 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZzDMvCl6WEbhw289ciW&open=AZzDMvCl6WEbhw289ciW&pullRequest=137
View more details on SonarQubeCloud