Skip to content

fix(clipPaths): Fix svg element clipping - CU-86c8x20du #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AshishBhattarai merged 1 commit into from
Mar 18, 2026
Merged

fix(clipPaths): Fix svg element clipping - CU-86c8x20du #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 24 additions & 12 deletions lib/write_svg.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,11 @@ export default function (doc, svg, x, y, options) {
white: [NamedColors.white, 1],
transparent: [NamedColors.black, 0],
};
const RGBDefaultColors = {
black: [NamedColors.black, 1],
white: [NamedColors.white, 1],
transparent: [NamedColors.black, 0],
};
const Entities = {
quot: 34,
amp: 38,
Expand Down Expand Up @@ -694,18 +699,16 @@ export default function (doc, svg, x, y, options) {
doc.page.xobjects[group.name] = group.xobj;
doc.addContent('/' + group.name + ' Do');
}
function docApplyMask(group, clip) {
function docApplyMask(group) {
let name = 'M' + (doc._maskCount = (doc._maskCount || 0) + 1);
let gstate = doc.ref({
Type: 'ExtGState',
CA: 1,
ca: 1,
BM: 'Normal',
SMask: {
// Needs to be Alpha for clipping to work with cmyk color space
// Clipping mode is reproducing svg clip-path by drawing everything inside clip path with DefaultColors.white [1,1,1,1]
// And everything outside (not draw, defaults to [0,0,0,0]) is masked off
S: clip ? 'Alpha' : 'Luminosity',
// This should ideally be an Alpha mask for clipping but when we set it to Alpha the firefox pdf viewer doesn't render masks correctly
S: 'Luminosity',
G: group.xobj,
BC: maskBackdrop,
},
Expand Down Expand Up @@ -850,7 +853,16 @@ export default function (doc, svg, x, y, options) {
function docEndText() {
doc.addContent('ET');
}
function docFillColor(color) {
function docFillColor(color, isClip) {
if (isClip) {
// always write clips in RGB colorspace
const oldColorProfile = doc._activeColorProfile;
doc._activeColorProfile = null;
doc.fillColor(RGBDefaultColors.white[0], RGBDefaultColors.white[1]);
doc._activeColorProfile = oldColorProfile;
return;
}

if (color[0].constructor.name === 'PDFPattern') {
doc.fillOpacity(color[1]);
docUsePattern(color[0], false);
Expand Down Expand Up @@ -2747,7 +2759,7 @@ export default function (doc, svg, x, y, options) {
doc.image(image, 0, 0);
} else {
doc.rect(0, 0, image.width, image.height);
docFillColor(DefaultColors.white).fill();
docFillColor(DefaultColors.white, true);
}
doc.restore();
};
Expand Down Expand Up @@ -3099,7 +3111,7 @@ export default function (doc, svg, x, y, options) {
}
} else {
this.shape.insertInDocument();
docFillColor(DefaultColors.white);
docFillColor(DefaultColors.white, true);
doc.fill(this.get('clip-rule'));
}
doc.restore();
Expand Down Expand Up @@ -3312,7 +3324,7 @@ export default function (doc, svg, x, y, options) {
this.drawChildren(true, false);
doc.restore();
docEndGroup(group);
docApplyMask(group, true);
docApplyMask(group);
};
};

Expand Down Expand Up @@ -3340,7 +3352,7 @@ export default function (doc, svg, x, y, options) {
this.drawChildren(false, true);
doc.restore();
docEndGroup(group);
docApplyMask(group, false);
docApplyMask(group);
};
};

Expand Down Expand Up @@ -3412,7 +3424,7 @@ export default function (doc, svg, x, y, options) {
}
if (fill || stroke || isClip) {
if (fill) {
docFillColor(fill);
docFillColor(fill, isClip);
}
if (stroke && strokeWidth) {
docStrokeColor(stroke);
Expand Down Expand Up @@ -3446,7 +3458,7 @@ export default function (doc, svg, x, y, options) {
let fill = this.getFill(isClip, isMask),
stroke = this.getStroke(isClip, isMask);
if (fill) {
docFillColor(fill);
docFillColor(fill, isClip);
}
if (stroke) {
docStrokeColor(stroke);
Expand Down
Loading