Skip to content

Fix: add validation for config.json #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SyedaAnshrahGillani wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: add validation for config.json #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions kittentts/get_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,19 +75,28 @@ def download_from_huggingface(repo_id="KittenML/kitten-tts-nano-0.1", cache_dir=
with open(config_path, 'r') as f:
config = json.load(f)

# Validate config
if config.get("type") != "ONNX1":
raise ValueError("Unsupported model type.")
raise ValueError(f"Unsupported model type in config.json: {config.get('type')}. Only 'ONNX1' is supported.")

model_filename = config.get("model_file")
if not model_filename:
raise ValueError("The 'model_file' key is missing from config.json.")

voices_filename = config.get("voices")
if not voices_filename:
raise ValueError("The 'voices' key is missing from config.json.")

# Download model and voices files based on config
model_path = hf_hub_download(
repo_id=repo_id,
filename=config["model_file"],
filename=model_filename,
cache_dir=cache_dir
)

voices_path = hf_hub_download(
repo_id=repo_id,
filename=config["voices"],
filename=voices_filename,
cache_dir=cache_dir
)

Expand Down