Closed
Conversation
This was referenced Aug 6, 2025
Open
Closed
Open
This was referenced Aug 13, 2025
|
This needs to be rebased. |
* Remove the `misaki` dependency, but directly depend on `phonemizer-fork` instead. * Do the side-effect phonemizer initialization call by hand
akx
force-pushed
the
remove-unnecessary-dep
branch
from
03853c7 to
87e2cdd
Compare
Author
|
Thanks @ofek :) Rebased. Cc @therealron (noticed you were toying around with Misaki deps). |
Author
|
This was apparently done by the mysterious "Your Name" in f466f63. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misaki was apparently only used for the side effects of
phonemizer-forkespeakng_loaderThis will conflict with #24.