fix(agent-manager): recover worktrees after restart#9939
Open
marius-kilocode wants to merge 1 commit intomainfrom
Open
fix(agent-manager): recover worktrees after restart#9939marius-kilocode wants to merge 1 commit intomainfrom
marius-kilocode wants to merge 1 commit intomainfrom
Conversation
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| void this.shutdown() | ||
| } | ||
|
|
||
| private async disposeAsync(): Promise<void> { |
Contributor
There was a problem hiding this comment.
WARNING: Shutdown does not wait for terminal cleanup
shutdown() is now awaited during extension deactivation, but terminalRouter.dispose() is still fire-and-forget inside this async cleanup. This lets shutdown resolve before PTY removal requests finish, so the connection service can be torn down while cleanup is in flight and terminals may linger until the backend exits. Await that disposal in disposeAsync() so the new shutdown drain also covers terminal resources.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Resolved Issues
Reviewed by gpt-5.5-20260423 · 514,885 tokens |
marius-kilocode
force-pushed
the
quickest-wool
branch
2 times, most recently
from
31eac80 to
cbbce0f
Compare
marius-kilocode
force-pushed
the
quickest-wool
branch
from
cbbce0f to
56a43bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.kilo/worktreeswhen saved state is missing, stale, or corrupt.Fixes #9877