perf(cli): guard large-file reads and avoid sync patch I/O#9919
Open
kilo-code-bot[bot] wants to merge 1 commit intomainfrom
Open
perf(cli): guard large-file reads and avoid sync patch I/O#9919kilo-code-bot[bot] wants to merge 1 commit intomainfrom
kilo-code-bot[bot] wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by gpt-5.5-2026-04-23 · 242,365 tokens |
Cap jschardet detection to a 64 KB prefix, reject reads of files larger than 10 MB in the read tool, and make deriveNewContentsFromChunks async so apply_patch no longer blocks the event loop on large files.
7650dc9 to
55b19b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review remarks about memory blowup and event-loop blocking on large file reads.
Changes
encoding.ts: Cap jschardet detection to a 64 KB prefix. Valid UTF-8 bytes still short-circuit before detection; only non-UTF-8 inputs hit the sampler, so accuracy is unaffected.tool/read.ts: Reject files over 10 MB before callingEncoding.read, since the encoding-aware path buffers the whole file for BOM detection / iconv decode (a regression from the priorcreateReadStreampath for multi-GB files).patch/index.ts+tool/apply_patch.ts: ConvertderiveNewContentsFromChunksto async and replaceEncoding.readSyncwithEncoding.readso the apply-patch flow no longer does blocking I/O on the Node event loop. All callers already live in async contexts.