Skip to content

cloud-build-docker: stop clobbering :latest on PR builds #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwbron merged 1 commit into from
May 19, 2026
Merged

cloud-build-docker: stop clobbering :latest on PR builds #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions terraform/modules/cloud-build-docker/cloudbuild.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,17 +32,11 @@ steps:
--build-arg BASE_IMAGE="$_BASE_DIGEST" \
.

- name: 'gcr.io/cloud-builders/docker'
id: Tag cache image
entrypoint: bash
args: ['-c', 'docker tag "$_IMAGE_TAG" "$_IMAGE_NAME:$_CACHE_TAG"']
waitFor: ['Build image with BuildKit']

- name: 'gcr.io/cloud-builders/docker'
id: Push cache image
entrypoint: bash
args: ['-c', 'docker push "$_IMAGE_NAME:$_CACHE_TAG"']
waitFor: ['Tag cache image']

# Only push the build's own tag ($_IMAGE_TAG). Do NOT also push under
# $_IMAGE_NAME:$_CACHE_TAG: that tag is chosen as a *read* fallback by
# build_image.py (it falls back to "latest" when the requested tag does
# not yet exist), and pushing the build under it would clobber whatever
# is currently at that tag. In practice this would let a first-time PR
# build overwrite the master image at :latest with its own content.
images:
- '$_IMAGE_TAG'
Loading