Closed
Conversation
* Implement teams app setup command and refactor common integration code * Remove unnecessary comments and imports * Change tenant_id and client_id as text instead of secret * Update docker service and container names * Update validation messgaes with expected pattern
Status and informational messages (login success, update notices, share request prompts, device confirmations, etc.) were being printed to stdout via print(), polluting piped output. For example, `keeper find-password <record> | pbcopy` would capture login messages along with the password. Changed all non-data print() calls to use logging (info/warning/error) which routes to stderr. In batch mode the log level is WARNING, so info-level messages are automatically suppressed while errors and warnings remain visible on stderr without polluting stdout. Also fixed alias help text: running `find-password -h` now correctly shows `usage: find-password` instead of `usage: clipboard-copy` by setting parser.prog to the alias name in execute_args().
* Added new example PAM import generator script * Added set_resource_jit_settings to extend.py (#1825) * Upgrade to keeper_pam_webrtc_rs>=2.0.1 * Added k8s config generation Allow empty string passwords for local accounts rotated by AD admin Allow only launch_creds without any admin_creds in pam extend Fixed JIT/AI settings handling during pam extend * Hotfix for pam_generator (#1827) fixed hostname attribute (=> host) improved mach template for better readability * Add support for type attribute in CSV (#1828) * Hotfix for pam_generator fixed hostname attribute (=> host) improved mach template for better readability * Improve type definitions in pam_generator_v2 Support for the type column to be added to the CSV and override the type attribute from the template. * fix: extend lookups should check vault records --------- Co-authored-by: fameti-cymk <fameti@keepersecurity.com> Co-authored-by: lthievenaz-keeper <lthievenaz@keepersecurity.com>
…iltering regression (#1837) The user_filter optimization from PR #1814 narrowed the compliance data fetch when --email/--username was specified, excluding shared records owned by other users from the result set. This broke --report-type vault (which needs the full sharing graph) and understated summary-report total_items. Fix: add needs_full_sharing_data flag to BaseComplianceReportCommand that bypasses data-level user_filter while preserving report-level filtering. Applied to record-access-report and summary-report. Also fix a pre-existing bug where last_aging_refreshed was updated without actually fetching aging data (empty rec_ids on cold cache). Add A/B test harness (tests/compliance/) with field-level JSON diff, Windows/MSYS compatibility, auto-discovery, and KC-1142 regression tests.
#1838) Interactive login prompts (SSO menu, 2FA method selection, device approval options, password context) were using logging.info() which is suppressed in batch mode (log level=WARNING). Users running commands like `keeper find-password` saw bare "Selection:" prompts with no menu options visible. Changed all interactive auth UI in console_ui.py and loginv3.py to use print(file=sys.stderr) which is always visible regardless of log level while still keeping output off stdout for clean piping. Also suppress "Successfully authenticated with Persistent Login" in batch mode since it adds noise to every one-shot command when the user has persistent login enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.