KC-1156 Fix compliance record-access-report user_filter regression#1837
Merged
craiglurey merged 1 commit intoreleasefrom Feb 24, 2026
Merged
KC-1156 Fix compliance record-access-report user_filter regression#1837craiglurey merged 1 commit intoreleasefrom
craiglurey merged 1 commit intoreleasefrom
Conversation
…iltering regression The user_filter optimization from PR #1814 narrowed the compliance data fetch when --email/--username was specified, excluding shared records owned by other users from the result set. This broke --report-type vault (which needs the full sharing graph) and understated summary-report total_items. Fix: add needs_full_sharing_data flag to BaseComplianceReportCommand that bypasses data-level user_filter while preserving report-level filtering. Applied to record-access-report and summary-report. Also fix a pre-existing bug where last_aging_refreshed was updated without actually fetching aging data (empty rec_ids on cold cache). Add A/B test harness (tests/compliance/) with field-level JSON diff, Windows/MSYS compatibility, auto-discovery, and KC-1142 regression tests.
sk-keeper
pushed a commit
that referenced
this pull request
Feb 25, 2026
…iltering regression (#1837) The user_filter optimization from PR #1814 narrowed the compliance data fetch when --email/--username was specified, excluding shared records owned by other users from the result set. This broke --report-type vault (which needs the full sharing graph) and understated summary-report total_items. Fix: add needs_full_sharing_data flag to BaseComplianceReportCommand that bypasses data-level user_filter while preserving report-level filtering. Applied to record-access-report and summary-report. Also fix a pre-existing bug where last_aging_refreshed was updated without actually fetching aging data (empty rec_ids on cold cache). Add A/B test harness (tests/compliance/) with field-level JSON diff, Windows/MSYS compatibility, auto-discovery, and KC-1142 regression tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
tests/compliance/run.sh after)tests/compliance/run.sh all)