Skip to content

fix: build wasm failed#487

Open
duyquang6 wants to merge 1 commit intoKeats:masterfrom
duyquang6:push-ztqznkqopwqz
Open

fix: build wasm failed#487
duyquang6 wants to merge 1 commit intoKeats:masterfrom
duyquang6:push-ztqznkqopwqz

Conversation

@duyquang6
Copy link

@duyquang6 duyquang6 commented Mar 3, 2026

Close #488

we need enable js feature on getrandom lib

@duyquang6 duyquang6 force-pushed the push-ztqznkqopwqz branch from 0e34ba2 to 7c915f1 Compare March 3, 2026 06:03
@Keats
Copy link
Owner

Keats commented Mar 3, 2026

You can already do that manually: https://github.com/Keats/jsonwebtoken/blob/master/.github/workflows/ci.yml#L83
I would rather update the getrandom crate first

@duyquang6
Copy link
Author

duyquang6 commented Mar 3, 2026

You can already do that manually: https://github.com/Keats/jsonwebtoken/blob/master/.github/workflows/ci.yml#L83 I would rather update the getrandom crate first

Should we update the getrandom crate first? I can help with that if needed.

@Keats
Copy link
Owner

Keats commented Mar 6, 2026

Yes, update first. I think the feature changed as well in recent versions?

@duyquang6
Copy link
Author

Yes, update first. I think the feature changed as well in recent versions?

okay, I'll check and update it first. looks like the optional feature was changed from js to wasmjs in recent versions as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot build with target wasm

2 participants