Closed
Conversation
I guess something changed upstream, but in-tree builds are disabled on line 4 of their CMakeLists.txt, meaning we have to do something different on our end. 1) added CMAKE_OUTSOURCE to force an inner "build" dir to be made. 2) added NOCOPY_TARGET, or else the build would fail trying to copy the target unecessarily, since the "cmake install" step already copies.
gyrovorbis
added
the
build failure
darcagn
approved these changes
Feb 26, 2026
darcagn
requested changes
Feb 26, 2026
Contributor
darcagn
left a comment
darcagn
left a comment
There was a problem hiding this comment.
In my test, the library file doesn't actually end up going to inst dir, so it isn't installed, even though it signals a success.
Member
|
Updated this and added a preinstall action to get the lib to install correctly in #146 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I guess something changed upstream, but in-tree builds are disabled on line 4 of their CMakeLists.txt, meaning we have to do something different on our end.
target unecessarily, since the "cmake install" step already copies.