Symbol enum can replace Segoe MDL2 Assets strings#6
Open
Adaok wants to merge 1 commit intoJustinXinLiu:masterfrom
Open
Symbol enum can replace Segoe MDL2 Assets strings#6Adaok wants to merge 1 commit intoJustinXinLiu:masterfrom
Adaok wants to merge 1 commit intoJustinXinLiu:masterfrom
Conversation
replace Segoe MDL2 Assets string by Symbol enum for easy choice icon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Justin,
I would like to make a suggestion regarding your code: I think it could be a good idea to replace your Icon in the MenuItem with the Symbol enum. What do you think about it?
I find it more useful to make items.
I know this causes to loose many symbols of the font, but it does make coding more comfortable.
It also seems like it makes it impossible to change the font size of the symbol, but it is not that much of an inconvenience for the UI.
One last question, could you please tell me how to change the size of the Pane ?
Thank you for your attention,
Marco