Conversation
Previously, the SplitView pane would stay open when the currently selected MenuItem is selected again. This has been fixed.
A swipe gesture should only ever be interpreted as horizontal or vertical—not both. Previously, if IsPanSelectorEnabled was true, a vertical swipe would usually open the SplitView pane. Other visual improvements were made to enhance the swiping experience.
|
I also fixed up the comments in ManipulationCompleted. :-) I just added punctuation and capitalized the first letter of each. I only modified the comments in that method since it's the only method I modified. But really nice work on this control. I really like the use of the ListBox, too. |
|
Thanks! But looks like the changes you made in the |
|
Also I'd like to keep the code in |
|
Sorry. The up and down pan was working for me :-( Also, the link you posted is dead. |
|
Sorry, just updated the link. Try this:
You will notice that the very top item gets highlighted, which is wrong. The 2nd last item should be highlighted instead. |
|
I'll give that a shot. But before my changes, I noticed that both the up/down pan and open/close swipe behaved in an unusual way. I'll take a look a bit later and see if there is a way to redo my fix without modifying Shell/ShellViewModel and without breaking the up/down pan. |
|
Thanks @chrisleyva ! Appreciate your help on this. |
The SplitView pane is now closed when selecting the previously selected MenuItem.
The swiping gesture logic has been fixed to improve the experience of using the swipable SplitView.