Skip to content

fix: Add required 'type' field to MCP tool responses and remove unsupported version argument #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ddonghi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Add required 'type' field to MCP tool responses and remove unsupported version argument #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 23 additions & 25 deletions src/server/databricks_mcp_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,7 @@ class DatabricksMCPServer(FastMCP):

def __init__(self):
"""Initialize the Databricks MCP server."""
super().__init__(name="databricks-mcp",
version="1.0.0",
instructions="Use this server to manage Databricks resources")
super().__init__(name="databricks-mcp")
logger.info("Initializing Databricks MCP server")
logger.info(f"Databricks host: {settings.DATABRICKS_HOST}")

Expand All @@ -55,10 +53,10 @@ async def list_clusters(params: Dict[str, Any]) -> List[TextContent]:
logger.info(f"Listing clusters with params: {params}")
try:
result = await clusters.list_clusters()
return [{"text": json.dumps(result)}]
return [{"type": "text", "text": json.dumps(result)}]
except Exception as e:
logger.error(f"Error listing clusters: {str(e)}")
return [{"text": json.dumps({"error": str(e)})}]
return [{"type": "text", "text": json.dumps({"error": str(e)})}]

@self.tool(
name="create_cluster",
Expand All @@ -68,10 +66,10 @@ async def create_cluster(params: Dict[str, Any]) -> List[TextContent]:
logger.info(f"Creating cluster with params: {params}")
try:
result = await clusters.create_cluster(params)
return [{"text": json.dumps(result)}]
return [{"type": "text", "text": json.dumps(result)}]
except Exception as e:
logger.error(f"Error creating cluster: {str(e)}")
return [{"text": json.dumps({"error": str(e)})}]
return [{"type": "text", "text": json.dumps({"error": str(e)})}]

@self.tool(
name="terminate_cluster",
Expand All @@ -81,10 +79,10 @@ async def terminate_cluster(params: Dict[str, Any]) -> List[TextContent]:
logger.info(f"Terminating cluster with params: {params}")
try:
result = await clusters.terminate_cluster(params.get("cluster_id"))
return [{"text": json.dumps(result)}]
return [{"type": "text", "text": json.dumps(result)}]
except Exception as e:
logger.error(f"Error terminating cluster: {str(e)}")
return [{"text": json.dumps({"error": str(e)})}]
return [{"type": "text", "text": json.dumps({"error": str(e)})}]

@self.tool(
name="get_cluster",
Expand All @@ -94,10 +92,10 @@ async def get_cluster(params: Dict[str, Any]) -> List[TextContent]:
logger.info(f"Getting cluster info with params: {params}")
try:
result = await clusters.get_cluster(params.get("cluster_id"))
return [{"text": json.dumps(result)}]
return [{"type": "text", "text": json.dumps(result)}]
except Exception as e:
logger.error(f"Error getting cluster info: {str(e)}")
return [{"text": json.dumps({"error": str(e)})}]
return [{"type": "text", "text": json.dumps({"error": str(e)})}]

@self.tool(
name="start_cluster",
Expand All @@ -107,10 +105,10 @@ async def start_cluster(params: Dict[str, Any]) -> List[TextContent]:
logger.info(f"Starting cluster with params: {params}")
try:
result = await clusters.start_cluster(params.get("cluster_id"))
return [{"text": json.dumps(result)}]
return [{"type": "text", "text": json.dumps(result)}]
except Exception as e:
logger.error(f"Error starting cluster: {str(e)}")
return [{"text": json.dumps({"error": str(e)})}]
return [{"type": "text", "text": json.dumps({"error": str(e)})}]

# Job management tools
@self.tool(
Expand All @@ -121,10 +119,10 @@ async def list_jobs(params: Dict[str, Any]) -> List[TextContent]:
logger.info(f"Listing jobs with params: {params}")
try:
result = await jobs.list_jobs()
return [{"text": json.dumps(result)}]
return [{"type": "text", "text": json.dumps(result)}]
except Exception as e:
logger.error(f"Error listing jobs: {str(e)}")
return [{"text": json.dumps({"error": str(e)})}]
return [{"type": "text", "text": json.dumps({"error": str(e)})}]

@self.tool(
name="run_job",
Expand All @@ -135,10 +133,10 @@ async def run_job(params: Dict[str, Any]) -> List[TextContent]:
try:
notebook_params = params.get("notebook_params", {})
result = await jobs.run_job(params.get("job_id"), notebook_params)
return [{"text": json.dumps(result)}]
return [{"type": "text", "text": json.dumps(result)}]
except Exception as e:
logger.error(f"Error running job: {str(e)}")
return [{"text": json.dumps({"error": str(e)})}]
return [{"type": "text", "text": json.dumps({"error": str(e)})}]

# Notebook management tools
@self.tool(
Expand All @@ -149,10 +147,10 @@ async def list_notebooks(params: Dict[str, Any]) -> List[TextContent]:
logger.info(f"Listing notebooks with params: {params}")
try:
result = await notebooks.list_notebooks(params.get("path"))
return [{"text": json.dumps(result)}]
return [{"type": "text", "text": json.dumps(result)}]
except Exception as e:
logger.error(f"Error listing notebooks: {str(e)}")
return [{"text": json.dumps({"error": str(e)})}]
return [{"type": "text", "text": json.dumps({"error": str(e)})}]

@self.tool(
name="export_notebook",
Expand All @@ -170,10 +168,10 @@ async def export_notebook(params: Dict[str, Any]) -> List[TextContent]:
summary = f"{content[:1000]}... [content truncated, total length: {len(content)} characters]"
result["content"] = summary

return [{"text": json.dumps(result)}]
return [{"type": "text", "text": json.dumps(result)}]
except Exception as e:
logger.error(f"Error exporting notebook: {str(e)}")
return [{"text": json.dumps({"error": str(e)})}]
return [{"type": "text", "text": json.dumps({"error": str(e)})}]

# DBFS tools
@self.tool(
Expand All @@ -184,10 +182,10 @@ async def list_files(params: Dict[str, Any]) -> List[TextContent]:
logger.info(f"Listing files with params: {params}")
try:
result = await dbfs.list_files(params.get("dbfs_path"))
return [{"text": json.dumps(result)}]
return [{"type": "text", "text": json.dumps(result)}]
except Exception as e:
logger.error(f"Error listing files: {str(e)}")
return [{"text": json.dumps({"error": str(e)})}]
return [{"type": "text", "text": json.dumps({"error": str(e)})}]

# SQL tools
@self.tool(
Expand All @@ -203,10 +201,10 @@ async def execute_sql(params: Dict[str, Any]) -> List[TextContent]:
schema = params.get("schema")

result = await sql.execute_sql(statement, warehouse_id, catalog, schema)
return [{"text": json.dumps(result)}]
return [{"type": "text", "text": json.dumps(result)}]
except Exception as e:
logger.error(f"Error executing SQL: {str(e)}")
return [{"text": json.dumps({"error": str(e)})}]
return [{"type": "text", "text": json.dumps({"error": str(e)})}]


async def main():
Expand Down