Skip to content

fix ply parser#115

Merged
SimonDanisch merged 2 commits intomasterfrom
sd/fix-ply
Mar 18, 2026
Merged

fix ply parser#115
SimonDanisch merged 2 commits intomasterfrom
sd/fix-ply

Conversation

@SimonDanisch
Copy link
Copy Markdown
Member

This fixes a couple of issues I run into testing pbrt scenes with Makie.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 95.04132% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.25%. Comparing base (bcaeb9a) to head (89475b6).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/io/ply.jl 95.04% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage   75.46%   79.25%   +3.79%     
==========================================
  Files          11       11              
  Lines         758      829      +71     
==========================================
+ Hits          572      657      +85     
+ Misses        186      172      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SimonDanisch SimonDanisch merged commit 202463d into master Mar 18, 2026
3 of 4 checks passed
@SimonDanisch SimonDanisch deleted the sd/fix-ply branch March 18, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant