Add support for alignment in lines with zero-width characters#976
Merged
pfitzseb merged 4 commits intoMay 22, 2026
Merged
Conversation
Contributor
Author
|
Bump! |
Contributor
Author
|
Bump 2! |
pfitzseb
approved these changes
May 20, 2026
Contributor
pfitzseb
left a comment
pfitzseb
left a comment
There was a problem hiding this comment.
It's a bit confusing that FST.line_offset and State.line_offset talk about char offsets, but AlignGroup.line_offsets contains textwidth-based offsets, but the change LGTM otherwise.
Contributor
|
Can you run JuliaFormatter on this please? CI is complaining about some files not being formatted properly. |
Contributor
Author
|
@pfitzseb Done! |
pfitzseb
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @domluna !
This commit should address the problem with alignment in lines with zero-width characters.
Closes #975