Conversation
3 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1003 +/- ##
===========================================
+ Coverage 49.33% 87.60% +38.27%
===========================================
Files 128 135 +7
Lines 7845 8078 +233
===========================================
+ Hits 3870 7077 +3207
+ Misses 3975 1001 -2974
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tentative fix for SciML/NonlinearSolve.jl#933 after #974 changed the array behavior of wrong-mode pushforward/pullback.
@ChrisRackauckas can you try out this version (0.7.18) and see if NonlinearSolve likes it better? I don't think it makes much difference on the DI side so I'm happy to merge it. Ideally, if your bot can provide a self-contained MWE I'll add it to the test suite to prevent regressions.