Add batched and multi-dimensional rfft/irfft support#60
Open
jamesquinlan wants to merge 1 commit into
Open
Conversation
Signed-off-by: jamesquinlan <james@stillwater-sc.com>
Collaborator
|
Awesome thanks for this effort! Feel free to keep @maximilian-gelbrecht and me updated about this progress. We have recently implemented MatrixSpectralTransform in SpeedyTransforms as it's fast at low resolutions with the side effect of being more type flexible as it only needs a matrix vector multiplication. But being able to use GenericFFT is also great! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
==========================================
+ Coverage 76.05% 80.82% +4.77%
==========================================
Files 2 2
Lines 213 266 +53
==========================================
+ Hits 162 215 +53
Misses 51 51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: add support for
AbstractMatrixand higher-dimAbstractArraytypes inrfftandirfft. It was needed to support workflows inSpeedyTransforms.jlwhich call plans on 2d views. Previously,generic_rfftonly handledAbstractVectorgiving aMehtodErrorfor matrces.New Features:
AbstractFFTsinterface.Minor Bug Fixes & Improvements:
plan_rfftstores length of the tranformed dimension instead of the total array lengthpinvinDummyPlanto allow real-input plans to store complex-output inverses.Verification:
test/fft_tests.jlof batached 1d rfft/irfft along different dimensions