fix: Text button in Edit PDF not working#5
Conversation
… state The annotation text input textarea had transparent background and tiny height (~25px at default font 18), making it invisible on white PDF pages. Also added cleanup effect to reset drawing/textBox state when switching tools, preventing stale state from swallowing canvas clicks. Fixes JhaSourav07#3
|
@xyaz1313 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Hey @xyaz1313! Thanks so much for opening this PR. The useEffect cleanup and the dark background fix are exactly what we needed to solve the visibility issue. Really appreciate the thorough debugging here! Before we hit merge, there is one critical UI conflict we need to tweak: The z-index issue: Our sticky toolbar at the top of the app runs at z-20. With the zIndex: 25 currently in your commit, the textarea will float over the navigation bar if a user clicks near the top edge of the page. Required Change: Could you update the textarea style to use zIndex: 15 instead? (Pro tip: you should also force color: "#ffffff" on the textarea so that if a user selects black text, it doesn't become invisible against the new dark background!) Once you push those updates to this branch, could you attach a quick GIF or screen recording here showing it working in your local environment? (Specifically, test adding a text box right near the top toolbar to confirm the z-index is layering perfectly). As soon as I see the GIF and the updated commit, I'll get this merged immediately. Great work on this so far! 🚀 |
2 participants
Fixes #3
Root Cause
The annotation text input textarea had transparent background and tiny height (~26px at default font size 18). On a white PDF page, the white text was completely invisible. No cleanup of drawing/textBox state on tool change caused stale state interference.
Changes
Summary by CodeRabbit
Bug Fixes
Improvements