Skip to content

fix: reduce atan calculations#1243

Open
baltzell wants to merge 1 commit intodevelopmentfrom
profiling-cvt
Open

fix: reduce atan calculations#1243
baltzell wants to merge 1 commit intodevelopmentfrom
profiling-cvt

Conversation

@baltzell
Copy link
Copy Markdown
Collaborator

@baltzell baltzell commented May 4, 2026 •
edited
Loading

asprof flamegraph: www.jlab.org/~baltzell/tmp/a

@baltzell baltzell requested a review from tongtongcao May 4, 2026 20:29
@baltzell baltzell added the speed label May 4, 2026
@baltzell baltzell changed the title feat: reduce atan calculations fix: reduce atan calculations May 4, 2026
@baltzell baltzell enabled auto-merge (squash) May 4, 2026 20:39
@baltzell
Copy link
Copy Markdown
Collaborator Author

baltzell commented May 4, 2026

after #1243, #1244, and #1245, the effect seems evident:

before: https://userweb.jlab.org/~baltzell/tmp/a
after: https://userweb.jlab.org/~baltzell/tmp/cpu.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zieglerv zieglerv Awaiting requested review from zieglerv zieglerv is a code owner

@raffaelladevita raffaelladevita Awaiting requested review from raffaelladevita raffaelladevita is a code owner

@tongtongcao tongtongcao Awaiting requested review from tongtongcao

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

speed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@baltzell