This repository was archived by the owner on Mar 9, 2020. It is now read-only.
Prevent index out of array bounds exception#475
Open
mason-mcglothlin wants to merge 1 commit intoJanKallman:masterfrom
Open
Prevent index out of array bounds exception#475mason-mcglothlin wants to merge 1 commit intoJanKallman:masterfrom
mason-mcglothlin wants to merge 1 commit intoJanKallman:masterfrom
Conversation
Convert short to int because we were overflowing the value and this was causing and index out of bounds exception when accessing an array. Eliminated unnecessary cast
kangzixiang
approved these changes
Jun 13, 2019
Author
|
@SachieKang I appreciate the review. Any idea when this might be merged and then pushed to nuget.org? Our company relies on EPPlus for generating some reports and we're trying to decide whether we need to temporarily fork EPPlus or if we can hold out for an official release. Knowing the timing would be helpful for our decision making. |
Author
|
Any updates on when this might get merged + released? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert short to int because we were overflowing the value and this was causing and index out of bounds exception when accessing an array. Eliminated unnecessary cast.
We are using EPPlus to generate an Excel report in our application. We were getting an index out of range exception when a particularly large report was coming through. We traced this down to an unnecessary cast of an index value to a short. Changing it to an int solved our problem.
I'm struggling to create an easily reproducible example of the error that I can share with you - the report that we generate contains Protected Health Information, and trying to create a simple example with canned fake data isn't appearing so fruitful at the moment. But I did verify that once we changed from short to int that it resolved our issue.