Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/small-windows-beg.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"lit-analyzer-fork": patch
---

Fix dependency visiting logic to exclude imports with type-only bindings
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,18 @@ function visitDirectImports(node: Node, context: IVisitDependenciesContext): voi
return;
}*/

const namedBindings = context.ts.isImportDeclaration(node) && node.importClause?.namedBindings;

// Exclude files that only have type imports like `import { type MyElement } from "./file1"`
if (
namedBindings &&
context.ts.isNamedImports(namedBindings) &&
namedBindings.elements.length > 0 &&
namedBindings.elements.every(e => e.isTypeOnly)
) {
return;
}

emitDirectModuleImportWithName(node.moduleSpecifier.text, node, context);
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,27 @@ tsTest("Ignores type-only imports in a file", t => {
t.deepEqual(sortedFileNames, ["file2.ts"]);
});

tsTest("Ignores imports with type-only bindings in a file", t => {
const { sourceFile, context } = prepareAnalyzer([
{ fileName: "file1.ts", text: `` },
{
fileName: "file2.ts",
text: `
import { type MyElement } from "./file1";
`,
entry: true
}
]);

const dependencies = parseAllIndirectImports(sourceFile, context);

const sortedFileNames = Array.from(dependencies)
.map(file => file.fileName)
.sort();

t.deepEqual(sortedFileNames, ["file2.ts"]);
});

tsTest("Ignores type-only exports in a file", t => {
const { sourceFile, context } = prepareAnalyzer([
{ fileName: "file1.ts", text: `` },
Expand Down