Replace Haskell git submodules with source-repository-package stanzas#3
Open
Jimbo4350 wants to merge 2 commits into
Open
Replace Haskell git submodules with source-repository-package stanzas#3Jimbo4350 wants to merge 2 commits into
Jimbo4350 wants to merge 2 commits into
Conversation
drop the hjsonpointer, hjsonschema and wai-routes submodules. hjsonpointer and hjsonschema move to source-repository-package entries pinned at the same commits the submodules referenced. wai-routes had no build-depends or imports referencing it and is removed outright (the stale comment and the -fno-warn-redundant-constraints pragma in Ogmios.App.Server.Http are removed with it).
the spec label and the file on disk are both Script_Native_0.json, but the decodeFileThrow call read Script_native_0.json. on case-sensitive filesystems the test failed with NoSuchThing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server/modules/and replace the two real Haskell dependencies withsource-repository-packagestanzas pinned at the same commits the submodules referenced:hjsonpointer@879f0e74d55eef76ceaec8f60ed07657ab84bad7hjsonschema@fc9cfe92723e305e6289e7c1733f3420d64dd9d5wai-routesoutright: nothing in the repobuild-dependson it, no source importsWai.Routes. The staleNOTEcomment and the-fno-warn-redundant-constraintspragma inOgmios.App.Server.Http(which existed only because of wai-routes) are removed with it.The non-Haskell submodules (
docs/themes/learn,server/config) are untouched — they aren't cabal inputs and are out of scope for this change.Test plan
cabal build allsucceedscabal test allruns the full unit suite (140 examples). Pre-existingScript_Native_0filename-casing bug surfaced and is fixed in a follow-up; this PR keeps the SRP migration self-contained.