Conversation
karknu
approved these changes
Feb 27, 2026
Contributor
karknu
left a comment
karknu
left a comment
There was a problem hiding this comment.
LGTM.
Just a spelling error and a suggestion.
| maxNumTxIdsToRequest = maxSigsInflight, | ||
| maxUnacknowledgedTxIds = 4 * maxSigsInflight, | ||
| txsSizeInflightPerPeer = maxSigSize * fromIntegral maxSigsInflight, | ||
| maxTxsSizeInflight = 250_000, |
Contributor
There was a problem hiding this comment.
How about using the text in the comment as maxTxsSizeInflight inflight limit instead of the lower 250k?
Contributor
Author
There was a problem hiding this comment.
The maxTxSizeInflight will go away soon, so I phrased it to be future-proof.
coot
force-pushed
the
coot/sig-ingress-limit
branch
from
cf58ec2 to
60fe179
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of changes
Checklist