Open
Conversation
coot
reviewed
Jan 15, 2026
coot
reviewed
Jan 15, 2026
coot
reviewed
Jan 15, 2026
the-headless-ghost
force-pushed
the
edgr/sig-submission-v2
branch
from
7f46a53 to
0880f8e
Compare
coot
reviewed
Jan 20, 2026
the-headless-ghost
force-pushed
the
edgr/sig-submission-v2
branch
from
13271d6 to
6883ba0
Compare
the-headless-ghost
force-pushed
the
edgr/sig-submission-v2
branch
2 times, most recently
from
2633dd1 to
4984046
Compare
coot
reviewed
Feb 16, 2026
the-headless-ghost
force-pushed
the
edgr/sig-submission-v2
branch
from
1616aa1 to
e6a5041
Compare
coot
approved these changes
Feb 25, 2026
Contributor
coot
left a comment
coot
left a comment
There was a problem hiding this comment.
I pushed one commit to replace MonadTimer with MonadTimer.SI.
Contributor
|
@jpraynaud no validation changes in this PR, only protocol changes. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Verify that `Sig` encoding produces a valid CBOR.
`SigSubmissionV2` protocol based on `ObjectDiffusion` from Peras. The client requests signatures while the server provides them (dual to `TxSubmission`). The patch provides: * protocol definition and GADT wrappers * CBOR codec * cddl specification checked against the codec * codec provides valid CBOR encoding (checked as a regular QC test rather than with the `cddl` tool)
Co-authored-by: coot <coot@coot.me>
Co-authored-by: coot <coot@coot.me>
Co-authored-by: coot <coot@coot.me>
Co-authored-by: coot <coot@coot.me>
coot
force-pushed
the
edgr/sig-submission-v2
branch
from
5c27157 to
16a1ca3
Compare
* use MonadTimer.SI * added type signatures
coot
force-pushed
the
edgr/sig-submission-v2
branch
from
16a1ca3 to
f955ed0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of changes
Closes #13
Checklist