Align tests with numpy 2.4.5#2920
Merged
Merged
Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Collaborator
|
Coverage is 78.233% — align-with-numpy-2.4.5 into master. No base build found for |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev0=py313h509198e_47 ran successfully. |
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
vlad-perevezentsev
approved these changes
May 18, 2026
Contributor
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
There was a problem hiding this comment.
LGTM
Thank you @antonwolfy
github-actions Bot
added a commit
that referenced
this pull request
May 18, 2026
This PR updates the tests to align with recent NumPy 2.4.5 release. Also it removes TODOs and workarounds for fixes now available in the latest NumPy. That PR also includes: - work around for NumPy 2.4.5 regression in `conj()` for boolean arrays - extending `gcd()` overflow testing with additional test cases - cleaning p unused `allow_fall_back_on_numpy` fixture in correlation tests The PR adds compatibility note to `CHANGELOG.md` indicating this release is going to be compatible with NumPy 2.4.5. 2c740b3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the tests to align with recent NumPy 2.4.5 release.
Also it removes TODOs and workarounds for fixes now available in the latest NumPy.
That PR also includes:
conj()for boolean arraysgcd()overflow testing with additional test casesallow_fall_back_on_numpyfixture in correlation testsThe PR adds compatibility note to
CHANGELOG.mdindicating this release is going to be compatible with NumPy 2.4.5.