allow to bypass API failure and still init a connection#294
Open
allow to bypass API failure and still init a connection#294
Conversation
tfardet
reviewed
Mar 19, 2026
Collaborator
tfardet
left a comment
tfardet
left a comment
There was a problem hiding this comment.
It looks OK apart from a small question I have on seemingly unrelated change.
I don't think we can test these on GH so I'll run them locally before merging
Collaborator
Author
|
I hadn't had the time yet to check what happened in the test log failure, so maybe don't merge it right away. I suspect there might be some changes to be done still. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#290
Allow to bypass failure on API A (because of server errors) when querying API B.