Skip to content

Transfert to inseefr#15

Merged
khaledlarbi merged 11 commits intomasterfrom
InseeFr_transfer
Sep 5, 2025
Merged

Transfert to inseefr#15
khaledlarbi merged 11 commits intomasterfrom
InseeFr_transfer

Conversation

@khaledlarbi
Copy link
Copy Markdown
Contributor

@khaledlarbi khaledlarbi commented Mar 20, 2025 •
edited
Loading

  • Change maintainer name and email (8514ef5)
  • Use Github Actions to check build on multiple platforms (macOS, Ubuntu, Windows ..)
  • Update cran-comments.md
  • Bump version from 0.3.2 to 0.3.3

haroine
haroine reviewed Sep 5, 2025
View reviewed changes
tests/testthat/test_calibration_small_dataset.R

test_that("Calibration on minimum bounds checks out", {

skip_if_not_installed("Rglpk")
Copy link
Copy Markdown
Collaborator

@haroine haroine Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a warning to make sure test don't pass silently without being executed anywhere

haroine
haroine approved these changes Sep 5, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@haroine haroine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khaledlarbi khaledlarbi merged commit bc46716 into master Sep 5, 2025
5 checks passed
@khaledlarbi khaledlarbi deleted the InseeFr_transfer branch September 5, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haroine haroine haroine approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@khaledlarbi @haroine