[CHORE] sync dev with master after v1.13.1#409
Conversation
…ort_to_master Release/chain v1.17.0 support to master
…into release/v1_13_to_master
…breaking changes in the future
Release/v1.13 to master
…on_compatibility [CHORE] enforce python version compatibility
📝 WalkthroughWalkthroughThe PR bumps the project version from 1.13.1 to 1.14.0-rc1 in pyproject.toml and adds a new 1.14.0 changelog entry with a placeholder date, preparing the codebase for the upcoming release. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Syncs the dev branch with master post v1.13.1 by advancing the package version and preparing the changelog for the next release cycle.
Changes:
- Bumped Poetry project version to
1.14.0-rc1. - Added a new
1.14.0section toCHANGELOG.mdas a placeholder for upcoming release notes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
pyproject.toml |
Updates the package version for the next release iteration. |
CHANGELOG.md |
Adds a new top-level release section for 1.14.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| [tool.poetry] | ||
| name = "injective-py" | ||
| version = "1.13.1" | ||
| version = "1.14.0-rc1" |
There was a problem hiding this comment.
tool.poetry.version must be a valid PEP 440 version. 1.14.0-rc1 is typically rejected by Python packaging tooling (expects 1.14.0rc1 for a release candidate), which can break poetry build/publish and downstream installs.
| version = "1.14.0-rc1" | |
| version = "1.14.0rc1" |
| [tool.poetry] | ||
| name = "injective-py" | ||
| version = "1.13.1" | ||
| version = "1.14.0-rc1" |
There was a problem hiding this comment.
The version in pyproject.toml (1.14.0-rc1) doesn’t match the new CHANGELOG header (1.14.0). If this is an RC, consider keeping the CHANGELOG section version consistent (or use an unreleased section until the final 1.14.0 cut).
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@CHANGELOG.md`:
- Line 5: Replace the non-standard placeholder date in the changelog header "##
[1.14.0] - 9999-99-99" with a conventional marker; update that header to use
"Unreleased" (preferred) or "TBD" instead of "9999-99-99" so it reads e.g. "##
[1.14.0] - Unreleased", keeping the rest of the line intact.
|
|
||
| All notable changes to this project will be documented in this file. | ||
|
|
||
| ## [1.14.0] - 9999-99-99 |
There was a problem hiding this comment.
Replace the non-standard placeholder date.
The placeholder date "9999-99-99" is unconventional and could cause confusion. Standard changelog conventions recommend using "Unreleased" or "TBD" for versions in development.
📝 Suggested alternatives
Option 1 (recommended): Use "Unreleased" following keepachangelog.com convention
-## [1.14.0] - 9999-99-99
+## [1.14.0] - UnreleasedOption 2: Use "TBD" placeholder
-## [1.14.0] - 9999-99-99
+## [1.14.0] - TBD📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ## [1.14.0] - 9999-99-99 | |
| ## [1.14.0] - Unreleased |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@CHANGELOG.md` at line 5, Replace the non-standard placeholder date in the
changelog header "## [1.14.0] - 9999-99-99" with a conventional marker; update
that header to use "Unreleased" (preferred) or "TBD" instead of "9999-99-99" so
it reads e.g. "## [1.14.0] - Unreleased", keeping the rest of the line intact.
devbranch with the latest changes inmasterafter v1.13.1 releaseSummary by CodeRabbit