Skip to content

feat: Add compose lint#47

Merged
LunarX merged 2 commits intomainfrom
add-compose-lint
Mar 17, 2026
Merged

feat: Add compose lint#47
LunarX merged 2 commits intomainfrom
add-compose-lint

Conversation

@LunarX
Copy link
Copy Markdown
Contributor

@LunarX LunarX commented Mar 4, 2026

@LunarX LunarX requested a review from sirambd March 4, 2026 13:50
@LunarX LunarX self-assigned this Mar 4, 2026
@LunarX LunarX force-pushed the add-compose-lint branch 4 times, most recently from 9f32afd to adc5786 Compare March 9, 2026 15:03
@LunarX LunarX force-pushed the add-compose-lint branch from adc5786 to c553cf1 Compare March 17, 2026 08:34
@github-actions
Copy link
Copy Markdown
Contributor

This review introduces a new lint baseline file and applies the com.infomaniak.core.compose.lint plugin to enforce Compose best practices. The baseline captures significant technical debt including Compose anti-patterns (missing modifiers, incorrect parameter ordering, unstable collections, and improper ViewModel injection), numerous unused string resources, German translation typos, and outdated Gradle dependencies. While the baseline approach allows the build to pass despite existing issues, the team should prioritize addressing the Compose-specific lint violations and removing dead code to improve code quality and maintainability.

#ai-review-summary

@github-actions
Copy link
Copy Markdown
Contributor

This PR/issue depends on:

@LunarX LunarX force-pushed the add-compose-lint branch from 78aaf2e to 807e9d6 Compare March 17, 2026 14:35
Comment thread app/lint-baseline.xml
Comment thread app/lint-baseline.xml
Comment thread build.gradle.kts
Comment thread app/lint-baseline.xml
@LunarX LunarX merged commit fcbce29 into main Mar 17, 2026
7 checks passed
@LunarX LunarX deleted the add-compose-lint branch March 17, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants