Prevent glitching on heater#1
Merged
IndyJoeA merged 1 commit intoIndyJoeA:masterfrom Aug 11, 2017
Merged
Conversation
Prevent glitching on heater by checking if heater should stay fully on or fully off during cycle.
Owner
|
Yes, good point. I see the same issue with the standard PIDArduino plugin. I will test this out soon. |
Contributor
Author
|
Yes I submitted a similar pull request to that plugin
Manuel83/cbpi-PIDArduino#2
There is another pull request trying to do the same (that I overlooked
before submitting mine)
Manuel83/cbpi-PIDArduino#1
…On Sat, Jul 29, 2017 at 10:22 AM IndyJoeA ***@***.***> wrote:
Yes, good point. I see the same issue with the standard PIDArduino plugin.
I will test this out soon.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAg6pPDFWWlYH_5y8qqK2Vo-azLQ8JJQks5sSes-gaJpZM4OZKF8>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent glitching on heater by checking if heater should stay fully on
or fully off during cycle.
I noticed on my system that when the heater should stay fully on or fully off it would glitch momentarily each cycle. It is very visible in the user interface but can also be seen on the LED on the SSR for the heater.