Skip to content

feat: Niquests for http/2 handling#437

Draft
Sung96kim wants to merge 3 commits intomasterfrom
feat/niquests
Draft

feat: Niquests for http/2 handling#437
Sung96kim wants to merge 3 commits intomasterfrom
feat/niquests

Conversation

@Sung96kim
Copy link
Contributor

Summary

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Jira story/task is put into PR title
  • Code has been self-reviewed
  • Hard-to-understand areas have been commented
  • Documentation has been updated
  • My changes generate no new warnings
  • Unit tests have been added for base functionality and known edge cases
  • Any dependent changes have been merged and published in downstream modules

name = path.name
dup_counts[path.stem] = 1
file_args.append(data)
file_args.append({"files": {"file": (name, fd)}})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird we do this with individual nested dicts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requests/niquests is just funny like that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants