fix: split loader-specific marking fluid recipes by AdolfoCarneiro · Pull Request #374 · Indemnity83/logistics

AdolfoCarneiro · 2026-05-16T19:56:07Z

 ## Summary                                                                                                                                                                              
                                                                                                                                                                                         
 Moves loader-specific recipe data out of common resources so NeoForge no longer tries to parse Fabric-only ingredient syntax.                                                           
                                                                                                                                                                                         
 ## Changes                                                                                                                                                                              
                                                                                                                                                                                         
 - Move the marking fluid crafting recipes from `common` to `fabric`.                                                                                                                    
 - Add NeoForge-specific marking fluid recipe JSON using `neoforge:ingredient_type`.                                                                                                     
 - Add NeoForge biome modifier JSON for tin and apatite ore worldgen.                                                                                                                    
                                                                                                                                                                                         
 ## Notes                                                                                                                                                                                
                                                                                                                                                                                         
 This PR fixes the NeoForge recipe parse errors that showed up during dedicated server startup.

coderabbitai · 2026-05-16T19:59:16Z

Warning

Rate limit exceeded

@AdolfoCarneiro has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 59 minutes and 4 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 362d3ab8-52e3-4471-b5cc-bd3a5052a7fa

📥 Commits

Reviewing files that changed from the base of the PR and between 9941b54 and 59a3a5b.

📒 Files selected for processing (91)

.gitignore
common/src/client/java/com/logistics/LogisticsAutomationClientModels.java
common/src/client/java/com/logistics/LogisticsPipeClientModels.java
common/src/client/java/com/logistics/automation/render/LaserQuarryBlockEntityRenderer.java
common/src/client/java/com/logistics/automation/render/LaserQuarryRenderState.java
common/src/client/java/com/logistics/automation/render/MarkerBlockEntityRenderer.java
common/src/client/java/com/logistics/automation/render/MarkerRenderState.java
common/src/client/java/com/logistics/pipe/render/PipeBlockEntityRenderer.java
common/src/client/java/com/logistics/pipe/render/PipeRenderState.java
common/src/client/java/com/logistics/pipe/render/RenderProfiler.java
common/src/client/java/com/logistics/pipe/render/TravelingItemRenderState.java
common/src/client/java/com/logistics/power/render/model/CableGeometry.java
common/src/main/java/com/logistics/power/cable/CableBlock.java
common/src/main/resources/assets/logistics/blockstates/power/copper_cable.json
common/src/main/resources/assets/logistics/blockstates/power/ender_cable.json
common/src/main/resources/assets/logistics/blockstates/power/gold_cable.json
common/src/main/resources/assets/logistics/models/block/power/creative_engine_bellow.json
common/src/main/resources/assets/logistics/models/block/power/creative_engine_piston.json
common/src/main/resources/assets/logistics/models/block/power/redstone_engine_bellow.json
common/src/main/resources/assets/logistics/models/block/power/redstone_engine_piston.json
common/src/main/resources/assets/logistics/models/block/power/stirling_engine_bellow.json
common/src/main/resources/assets/logistics/models/block/power/stirling_engine_piston.json
fabric/src/client/java/com/logistics/LogisticsAutomationClient.java
fabric/src/client/java/com/logistics/LogisticsPipeClient.java
fabric/src/client/java/com/logistics/power/render/model/CableModel.java
fabric/src/main/resources/assets/logistics/blockstates/power/copper_cable.json
fabric/src/main/resources/assets/logistics/blockstates/power/ender_cable.json
fabric/src/main/resources/assets/logistics/blockstates/power/gold_cable.json
fabric/src/main/resources/data/logistics/recipe/pipe/black_marking_fluid.json
fabric/src/main/resources/data/logistics/recipe/pipe/blue_marking_fluid.json
fabric/src/main/resources/data/logistics/recipe/pipe/brown_marking_fluid.json
fabric/src/main/resources/data/logistics/recipe/pipe/cyan_marking_fluid.json
fabric/src/main/resources/data/logistics/recipe/pipe/gray_marking_fluid.json
fabric/src/main/resources/data/logistics/recipe/pipe/green_marking_fluid.json
fabric/src/main/resources/data/logistics/recipe/pipe/light_blue_marking_fluid.json
fabric/src/main/resources/data/logistics/recipe/pipe/light_gray_marking_fluid.json
fabric/src/main/resources/data/logistics/recipe/pipe/lime_marking_fluid.json
fabric/src/main/resources/data/logistics/recipe/pipe/magenta_marking_fluid.json
fabric/src/main/resources/data/logistics/recipe/pipe/orange_marking_fluid.json
fabric/src/main/resources/data/logistics/recipe/pipe/pink_marking_fluid.json
fabric/src/main/resources/data/logistics/recipe/pipe/purple_marking_fluid.json
fabric/src/main/resources/data/logistics/recipe/pipe/red_marking_fluid.json
fabric/src/main/resources/data/logistics/recipe/pipe/white_marking_fluid.json
fabric/src/main/resources/data/logistics/recipe/pipe/yellow_marking_fluid.json
neoforge/build.gradle
neoforge/src/main/java/com/logistics/neoforge/LogisticsNeoForge.java
neoforge/src/main/java/com/logistics/neoforge/NeoForgeCapabilityRegistration.java
neoforge/src/main/java/com/logistics/neoforge/NeoForgeChestLootModifier.java
neoforge/src/main/java/com/logistics/neoforge/NeoForgeCommandRegistration.java
neoforge/src/main/java/com/logistics/neoforge/NeoForgeCreativeTabSetup.java
neoforge/src/main/java/com/logistics/neoforge/NeoForgeNetworkTickHandler.java
neoforge/src/main/java/com/logistics/neoforge/NeoForgePacketRegistration.java
neoforge/src/main/java/com/logistics/neoforge/NeoForgeServerLevelEvents.java
neoforge/src/main/java/com/logistics/neoforge/client/NeoForgeClientSetup.java
neoforge/src/main/java/com/logistics/neoforge/client/render/EngineRenderState.java
neoforge/src/main/java/com/logistics/neoforge/client/render/NeoForgeCableBlockModelDefinition.java
neoforge/src/main/java/com/logistics/neoforge/client/render/NeoForgeCableModel.java
neoforge/src/main/java/com/logistics/neoforge/client/render/NeoForgeEngineBlockEntityRenderer.java
neoforge/src/main/java/com/logistics/neoforge/client/render/NeoForgeModelLoader.java
neoforge/src/main/java/com/logistics/neoforge/energy/NeoForgeEnergyCapabilityLookup.java
neoforge/src/main/java/com/logistics/neoforge/energy/NeoForgeEnergyStorage.java
neoforge/src/main/java/com/logistics/neoforge/fluids/NeoForgeFluidKey.java
neoforge/src/main/java/com/logistics/neoforge/fluids/NeoForgeFluidStorage.java
neoforge/src/main/java/com/logistics/neoforge/platform/NeoForgeCreativeTabRegistrar.java
neoforge/src/main/java/com/logistics/neoforge/platform/NeoForgePlatformService.java
neoforge/src/main/java/com/logistics/neoforge/platform/NeoForgeRegistryAliasHelper.java
neoforge/src/main/java/com/logistics/neoforge/storage/NeoForgeItemKey.java
neoforge/src/main/java/com/logistics/neoforge/storage/NeoForgeItemStorage.java
neoforge/src/main/resources/assets/logistics/blockstates/power/copper_cable.json
neoforge/src/main/resources/assets/logistics/blockstates/power/ender_cable.json
neoforge/src/main/resources/assets/logistics/blockstates/power/gold_cable.json
neoforge/src/main/resources/data/logistics/neoforge/biome_modifier/apatite_ore_stone.json
neoforge/src/main/resources/data/logistics/neoforge/biome_modifier/tin_ore_deepslate.json
neoforge/src/main/resources/data/logistics/neoforge/biome_modifier/tin_ore_stone.json
neoforge/src/main/resources/data/logistics/recipe/pipe/black_marking_fluid.json
neoforge/src/main/resources/data/logistics/recipe/pipe/blue_marking_fluid.json
neoforge/src/main/resources/data/logistics/recipe/pipe/brown_marking_fluid.json
neoforge/src/main/resources/data/logistics/recipe/pipe/cyan_marking_fluid.json
neoforge/src/main/resources/data/logistics/recipe/pipe/gray_marking_fluid.json
neoforge/src/main/resources/data/logistics/recipe/pipe/green_marking_fluid.json
neoforge/src/main/resources/data/logistics/recipe/pipe/light_blue_marking_fluid.json
neoforge/src/main/resources/data/logistics/recipe/pipe/light_gray_marking_fluid.json
neoforge/src/main/resources/data/logistics/recipe/pipe/lime_marking_fluid.json
neoforge/src/main/resources/data/logistics/recipe/pipe/magenta_marking_fluid.json
neoforge/src/main/resources/data/logistics/recipe/pipe/orange_marking_fluid.json
neoforge/src/main/resources/data/logistics/recipe/pipe/pink_marking_fluid.json
neoforge/src/main/resources/data/logistics/recipe/pipe/purple_marking_fluid.json
neoforge/src/main/resources/data/logistics/recipe/pipe/red_marking_fluid.json
neoforge/src/main/resources/data/logistics/recipe/pipe/white_marking_fluid.json
neoforge/src/main/resources/data/logistics/recipe/pipe/yellow_marking_fluid.json
neoforge/src/test/java/com/logistics/neoforge/ServiceLoaderSmokeTest.java

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

AdolfoCarneiro added 6 commits May 16, 2026 15:55

Add NeoForge storage adapters

9703b9f

Implement NeoForge platform SPI services

5ecbfa3

Wire NeoForge capabilities

88c3788

Wire NeoForge networking and lifecycle

1eaa878

Wire NeoForge client renderers

a31078c

Split loader-specific marking fluid recipes

59a3a5b

AdolfoCarneiro marked this pull request as ready for review May 16, 2026 19:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: split loader-specific marking fluid recipes #374

fix: split loader-specific marking fluid recipes #374
AdolfoCarneiro wants to merge 6 commits into
Indemnity83:mc/26.1from
AdolfoCarneiro:pr/neoforge-data-recipes

AdolfoCarneiro commented May 16, 2026

Uh oh!

coderabbitai Bot commented May 16, 2026

Rate limit exceeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

AdolfoCarneiro commented May 16, 2026

Uh oh!

coderabbitai Bot commented May 16, 2026

Rate limit exceeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant