Add truthiness test cases for ensure_bool() validation#72
Merged
InauguralPhysicist merged 1 commit intomainfrom Nov 23, 2025
Merged
Conversation
Add comprehensive test cases that validate the ensure_bool() fix for scalar truthiness in control flow (already implemented in commit 87a28b4). Tests added: - truthiness_test.eigs: Countdown loop using scalar as condition Tests that 'loop while count' works when count is a raw double - loop_fast.eigs: Performance benchmark with 1M iterations Validates that scalar fast path achieves C-level performance (12ms) Also update .gitignore to exclude compiled benchmark binaries. Related to PR #60 (copilot/fix-truthiness-bug-in-loop)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comprehensive test cases that validate the ensure_bool() fix for scalar truthiness in control flow (already implemented in commit 87a28b4).
Tests added:
Also update .gitignore to exclude compiled benchmark binaries.
Related to PR #60 (copilot/fix-truthiness-bug-in-loop)